matthuisman / slyguy.addons

Github mirror of SlyGuy add-ons
https://www.matthuisman.nz/2020/02/slyguy-kodi-repository.html
285 stars 78 forks source link

DTS/IMAX audio on Disney+ #742

Closed kyl416 closed 4 months ago

kyl416 commented 4 months ago

Any chance you can make the DTS/IMAX audio tracks available in the Disney+ kodi addon?

It should be available for Queen Rock Montreal: https://www.disneyplus.com/browse/entity-ebfc8e47-7e5c-404d-84b3-b6681284b1bf

Here's the announcement about it that lists some compatible devices and additional titles: https://press.disneyplus.com/news/disney-plus-queen-rock-montreal-imax-enhanced-sound-dts

matthuisman commented 4 months ago

could you please test slyguy.disney.plus -> v0.16.4

It is getting the DTS-X audio into the playlist, but that track doesnt show on my Kodi 21. However, I believe Inputstream Adaptive is detecting it as if it cant detect codec it defaults to AAC. And im not seeing it all.

Makes me think its Kodi itself that is now showing it to me as my hardware doesnt support it.

But, let me know if it works for you :)

Oh - you'll need to enable it in addon settings -> Playback -> DTS-X

kyl416 commented 4 months ago

On Nexus (tested with Windows 10 and AndroidTV/NVidia Shield) the track appears, but it's being detected as "AAC 9.1" so the audio doesn't decode. On Omega (tested with Linux and Android/Samsung Phone) the track doesn't appear at all.

matthuisman commented 4 months ago

Do you have a device that actually supports DTS-X?

On Fri, 17 May 2024, 06:19 kyl416, @.***> wrote:

On Nexus (tested with Windows 10 and AndroidTV/NVidia Shield) the track appears, but it's being detected as "AAC 9.1" so the audio doesn't decode. On Omega (tested with Linux and Android/Samsung Phone) the track doesn't appear at all.

— Reply to this email directly, view it on GitHub https://github.com/matthuisman/slyguy.addons/issues/742#issuecomment-2115917218, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPQAKIK2B4DBGWM7C3S42TZCT2BBAVCNFSM6AAAAABHZIQKECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVHEYTOMRRHA . You are receiving this because you commented.Message ID: @.***>

kyl416 commented 4 months ago

My Nvidia Shield is connected to an AVR that supports DTS:X

DTS-X is backwards compatible so older versions of ffmpeg and older DTS capable AVRs can also decode it as DTS-HD MA without the DTS-X enhancements. i.e. There are some DTS:X demo files here which playback the audio as "DTS-HD MA" in both Nexus and Omega: https://www.demolandia.net/cinema/dts-demo-trailers-hd/page-6.html

So even if you aren't watching with a setup that supports the DTS-X enhancements, you will still get a better audio experience for the Queen Concert with it decoded as 9.1 DTS-HD MA instead of 5.1 Dolby Digital Plus.

I enabled the save manifest option, and the DTS-x stream is in the manifest_master file on Omega, so it might be a detection issue with inputstream.adaptive

#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="DTS-X",NAME="English",LANGUAGE="en",AUTOSELECT=YES,CHANNELS="10",URI="r/composite_448k_dtsx_en_PRIMARY_bc81d2d4-da6d-42d5-92ee-2810badb8d94_f50c42ab-1461-4efa-b36d-124d4da9487e.m3u8"
matthuisman commented 4 months ago

yup. I think Omega tried to add support for it and maybe not working :) Ill open an issue with them later tonight

Nexus - probably wouldnt worry about as they wont backport fixes for that. I can proxy and change the CODECS string to something it supports, but not sure if there is anything that would work

matthuisman commented 4 months ago

as per https://github.com/xbmc/inputstream.adaptive/pull/1558#issuecomment-2117153231, its going to be awhile and only Kodi 22 that can support this.

Therefore, i've set the setting visible to false in the addon in the meantime.

Closing this ticket as the add-on is supporting it - but it needs IA and Kodi to also support it

kyl416 commented 4 months ago

It might be something specific to the Disney+ audio stream that inputstream.adaptive can't handle.

I converted one of the DTSX samples to DASH and HLS and was able to play them with inputstream.adaptive after using your "dca" patch.