matthuisman / slyguy.addons

Github mirror of SlyGuy add-ons
https://www.matthuisman.nz/2020/02/slyguy-kodi-repository.html
260 stars 70 forks source link

Max does not auto pick / marks 4K qualities as yellow #774

Closed matejdro closed 5 days ago

matejdro commented 5 days ago

https://github.com/matthuisman/slyguy.addons/assets/507922/748e0925-b338-4a10-a4d2-6421aa386bca

Best quality options appear as yellow and they do not get auto-selected when picking "Best". But selecting them manually works fine.

Any idea what could cause this?

matthuisman commented 5 days ago

yellow means the system has detected them as not compatible.

Go check out the playback settings in Slyguy common :) Maybe "ignore display resolution" has been disabled or a max width / height has been set.

Im actually working on a big brand new settings system that wont use Kodi settings but my own plugin settings. This will allow for easily inheriting all the common settings or override them on a per-addon basis :)

On Wed, 26 Jun 2024 at 21:28, Matej Drobnič @.***> wrote:

https://github.com/matthuisman/slyguy.addons/assets/507922/748e0925-b338-4a10-a4d2-6421aa386bca

Best quality options appear as yellow and they do not get auto-selected when picking "Best". But selecting them manually works fine.

Any idea what could cause this?

— Reply to this email directly, view it on GitHub https://github.com/matthuisman/slyguy.addons/issues/774, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPQAKK5LUNLRII3D4QAX6TZJKCS7AVCNFSM6AAAAABJ5POQDSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3TIOBTGM2DKMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

matthuisman commented 5 days ago

@matejdro did you find what was causing it? can we close this?

matejdro commented 5 days ago

Yes, enabling "ignore display resolution" helped. Thanks!

matthuisman commented 5 days ago

Great. With that disabled, it'll only select resolutions upto the display size.

On Wed, 26 Jun 2024, 23:43 Matej Drobnič, @.***> wrote:

Yes, enabling "ignore display resolution" helped. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/matthuisman/slyguy.addons/issues/774#issuecomment-2191486016, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPQAKODZ63SSWYNSXU37J3ZJKSPNAVCNFSM6AAAAABJ5POQDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRGQ4DMMBRGY . You are receiving this because you commented.Message ID: @.***>

matejdro commented 4 days ago

Huh that's weird, because the display is definitely 4K. Maybe it uses android UI resolution (which as far as I'm aware, runs in 1080p)?

matthuisman commented 4 days ago

the code uses xbmc.getInfoLabel('System.ScreenWidth') and xbmc.getInfoLabel('System.ScreenHeight') So i suspect they must be returning a lower number Kodi might show these somewhere in the system info

matejdro commented 3 days ago

Yes, this appears to be the case:

image

image