search

mattiaerre / oc-hub

This repository has been created as a central hub for all the OpenComponents built by Mattia Richetto.
10 stars 2 forks source link

[DO NOT MERGE] how-to-requirejs #10

Closed mattiaerre closed 7 years ago

mattiaerre commented 7 years ago

Description

screen shot 2017-05-08 at 6 41 55 pm

mattiaerre commented 7 years ago

as per the conversation I've had w/ @navamgupta, it looks like there is an issue when oc-client is used in a require.js context.

https://github.com/opentable/oc/blob/master/src/components/oc-client/src/oc-client.js#L11

// todo: add more info/scenarios

mattiaerre commented 7 years ago

closing but keeping the branch