search

mattiamanzati / typings-material-ui

Typings from callemall/material-ui project as NPM Module
MIT License
3 stars 2 forks source link

Linting #8

Closed alitaheri closed 7 years ago

alitaheri commented 8 years ago

I think this project is big enough to enable linting. Do you agree? Should I set up tslint with some rules?

If so we should agree on some rules :sweat_smile:

  1. semicolon ( always or never ) [ ]
  2. new line at the end of each file ( yes or no ) [ ]
  3. indentation ( 2 or 4 ) [ ]
mattiamanzati commented 8 years ago

Sure! Linting would only be a good thing!

My usual setup:

  1. no semicolons
  2. yes, new line at end
  3. 4 spaces for indentation
alitaheri commented 8 years ago

mine is:

  1. semicolon
  2. yes
  3. 2 spaces

But I don't really care, as long as it's consistent :+1: We'll go with your preference :+1: :+1:

mattiamanzati commented 8 years ago

No problem; have a shot with what you like most :)

alitaheri commented 8 years ago

I'll do it when all the components are added to make sure it won't interfere. Besides there are other things that must be done to improve quality. So I'll just do it all at once when the main work is finished :grin: