search

mattias-persson / statamic-translation-manager

A Statamic V2 addon for importing and exporting translations
MIT License
5 stars 2 forks source link

Slug isn't exported for translation #10

Closed aryehraber closed 4 years ago

aryehraber commented 4 years ago

Noticed today that a page's slug doesn't get exported (same for entries, etc), even while the localizable option is set:

slug:
  type: text
  localizable: true

I noticed that Statamic actually always allows slugs to be translated, even if the above is missing or set to false. I feel that always adding isn't necessarily what users want, so I think it should only get exported if the above config is added to the fieldset.

I've just got this working locally, so can push a PR if interested!

mattias-persson commented 4 years ago

Ah, nice! I think I may have just expected slugs to not be translatable... I'd appreciate a PR! Thanks for your continued efforts to improve this addon ❤️