search

mattiash / angular-tablesort

Sort angularjs tables easily
MIT License
184 stars 66 forks source link

Add ability to specify a custom sorting function for a column #68

Closed tbroadley closed 7 years ago

mattiash commented 7 years ago

Your patch sounds reasonable, but unfortunately it no longer applies cleanly. Please fix that (and maybe #73 at the same time since they are bound to be in conflict with this one?) and then I can merge it.

SergeyCherman commented 7 years ago

@tbroadley Can you resubmit? Your changes are mostly still good, just don't need the default compare anymore. If you don't have time I'll make your changes on top of master and submit the PR.

tbroadley commented 7 years ago

@SergeyCherman Sure, I'll fix the merge conflicts right now.

tbroadley commented 7 years ago

@SergeyCherman Could you please take another look at these changes?

SergeyCherman commented 7 years ago

Looks good to me, thanks for the quick turn around!

SergeyCherman commented 7 years ago

@mattiash can you take a look and consider a merge and version bump?