Numeric values are not compared as numbers

mattiash / angular-tablesort

Sort angularjs tables easily

MIT License

184 stars 66 forks source link

Numeric values are not compared as numbers #72

Closed parttee closed 7 years ago

parttee commented 7 years ago

Intl.Collator should use numeric option when it is comparing numeric values. Now Intl.Collator casts numeric values to strings before comparison. I'm not sure if "numeric: true" works as expected with strings so maybe there should be two different collators

mattiash commented 7 years ago

This should be fixed in version 1.3.2