Use a smarter comparer aware of numbers and dates by default

mattiash / angular-tablesort

Sort angularjs tables easily

MIT License

185 stars 66 forks source link

Use a smarter comparer aware of numbers and dates by default #77

Closed nvivo closed 8 years ago

nvivo commented 8 years ago

This is a simpler attempt to solve issues around numeric sorting discussed on #72 and #73. This creates a new comparer function and uses direct numeric comparison for numbers and dates.

This should be good enough for defaults without having to deal with custom comparer functions for simple cases.

A custom comparer would still be good, but this solves a more urgent issue. And for now creating a filter that parses any value into a number would be enough to sort custom values.

nvivo commented 8 years ago

Any issues with this @mattiash ?

mattiash commented 8 years ago

Looks good. Thank you!

guarilha commented 8 years ago

can you update the bower version with this PR please?