search

mattiasholmqvist / evently

An event sourcing library for Clojure
https://github.com/mattiasholmqvist/evently
Eclipse Public License 1.0
3 stars 1 forks source link

Update Clojure and a few cosmetic changes #1

Closed bsima closed 8 years ago

bsima commented 8 years ago

This is a great library and I'm testing it out for use in production. I've got a few changes that I'd like, mostly cosmetic. Nothing here changes the functionality.

Let me know if you want me to do anything else before getting this merged upstream.

Edit: I would have signed all my commits but magit didn't pick up my git settings :rage: and I didn't notice until the last commit grrr

mattiasholmqvist commented 8 years ago

Hi Ben!

Cool to see that you like my small library. 👍 I'm merging your changes right away. Thanks for the cleanup!

Let me know how it works out for you and if you're missing anything else.

bsima commented 8 years ago

@mattiasholmqvist awesome, thanks for the quick reply! I might have some additional PRs as I start using evently in real code.

Might I also suggest bumping the version number to 0.1.1 and putting this on Clojars? From what I can tell this isn't up there yet -> https://clojars.org/search?q=evently

mattiasholmqvist commented 8 years ago

Absolutely!

Sounds great! Will put it up on clojars as soon as possible!

Skickat från min iPhone

24 maj 2016 kl. 23:01 skrev Ben Sima notifications@github.com:

@mattiasholmqvist awesome, thanks for the quick reply! I might have some additional PRs as I start using evently in real code.

Might I also suggest bumping the version number to 0.1.1 and putting this on Clojars? From what I can tell this isn't up there yet -> https://clojars.org/search?q=evently

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

mattiasholmqvist commented 8 years ago

Try this now:

https://clojars.org/evently

/Mattias

On Tue, May 24, 2016 at 11:01 PM, Ben Sima notifications@github.com wrote:

@mattiasholmqvist https://github.com/mattiasholmqvist awesome, thanks for the quick reply! I might have some additional PRs as I start using evently in real code.

Might I also suggest bumping the version number to 0.1.1 and putting this on Clojars? From what I can tell this isn't up there yet -> https://clojars.org/search?q=evently

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/mattiasholmqvist/evently/pull/1#issuecomment-221390724

bsima commented 8 years ago

woot woot!! thanks mattias!