search

mattiasholmqvist / evently

An event sourcing library for Clojure
https://github.com/mattiasholmqvist/evently
Eclipse Public License 1.0
3 stars 1 forks source link

Use clojure.spec for data validation #2

Open bsima opened 8 years ago

bsima commented 8 years ago

When Clojure 1.9 is released along with the new clojure.spec library, we can replace these functions with spec declarations.

mattiasholmqvist commented 8 years ago

Absolutely. Sounds like a good idea!

/M

On Tue, May 31, 2016 at 9:20 PM, Ben Sima notifications@github.com wrote:

When Clojure 1.9 is released along with the new clojure.spec library, we can replace these functions https://github.com/mattiasholmqvist/evently/blob/master/src/evently/core.clj#L11-L31 with spec declarations.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mattiasholmqvist/evently/issues/2, or mute the thread https://github.com/notifications/unsubscribe/AACgBnm2IPQuMBSN3GCA9PMocGdsZbE3ks5qHIoSgaJpZM4Iq3cG .

bsima commented 8 years ago

FYI I'm working on this in my fork. A PR is forthcoming (gimme a day or so). I'm including test.check tests as well.

mattiasholmqvist commented 8 years ago

Cool Ben!

On Tue, Jun 21, 2016 at 7:59 PM, Ben Sima notifications@github.com wrote:

FYI I'm working on this in my fork. A PR is forthcoming (gimme a day or so). I'm including test.check tests as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mattiasholmqvist/evently/issues/2#issuecomment-227521125, or mute the thread https://github.com/notifications/unsubscribe/AACgBmRMWpdyDnszAqcEpS1dRwBe8ARoks5qOCaagaJpZM4Iq3cG .