search

mattickx / jsvat-next

Check the validity of the format of an EU VAT number
MIT License
9 stars 0 forks source link

Create a real UMD script #12

Closed ZsharE closed 2 months ago

ZsharE commented 2 months ago
mattickx commented 2 months ago

As this is basically just a dependency change, could you explain to me the benefit of this compared to the currently implemented UMD package?

ZsharE commented 2 months ago

The current UMD package cannot be loaded in the browser.

There is an open issue in the original repository that addresses this issue here: https://github.com/se-panfilov/jsvat/issues/105

I also changed the build:umd script in the package.json file.

mattickx commented 2 months ago

The current UMD package cannot be loaded in the browser.

There is an open issue in the original repository that addresses this issue here: se-panfilov#105

I also changed the build:umd script in the package.json file.

Thanks for clarifying. Could you provide a simple index.html with a simple example in, such that this can be tested for this PR and in the future aswell please ?

ZsharE commented 2 months ago

Test page added.

mattickx commented 2 months ago

I've added your changes but your yarn.lock file still had remainders of your attempt from PR #11

For some reason my editor created a new PR (PR #13). I've used PR #13 to merge this in, and gave you credit there. I've also linked back to this PR.

Thank you for your contribution! 🚀

mattickx commented 2 months ago

@ZsharE Forgot to publish a new version on npm, which I have done so just now