search

mattico / elasticlunr-rs

A partial port of elasticlunr to Rust. Intended to be used for generating compatible search indices.
Apache License 2.0
52 stars 23 forks source link

Allow to opt-out of Chinese/Japanese support #28

Closed Xanewok closed 4 years ago

Xanewok commented 4 years ago

While it's awesome to have, the relevant support doubles the amount of dependencies from 50 to 93, pulling some data/index crates, which can blow up the compilation time considerably, even if the user doesn't require the relevant language support.

It's great to have them enabled by the default but this commit allows to opt out via --no-default-features --features stemmer, without forcing the user to enumerate every language already supported by the rust-stemmers crate.

Xanewok commented 4 years ago

Not feeling particularly strong about the stemmers feature, feel free to skip it if you feel like it.

I'd love to land the first commit, which jieba-rs and lindera dependencies being made optional, though :heart:

Xanewok commented 4 years ago

Dropped the second commit to only fix the misconfigured features in the manifest.

mattico commented 4 years ago

Thank you! I should have noticed that after merging those.

Xanewok commented 4 years ago

Thanks for merging and releasing a new version!