search

mattieha / slider-button-card

A button card with integrated slider
MIT License
430 stars 68 forks source link

Fan slider not working, can only toggle off / on since latest core release #180

Open Avatar1976 opened 2 years ago

Avatar1976 commented 2 years ago

Version 1.10.3

Suspect compatibility issue with latest version of HASS core.

Home Assistant mobile app latest version, edge, Chrome, Samsung Internet all tested

Description of problem:

When attempting to use the slider to adjust fan speed it is not working, suspect it cannot read/set fan setting values.

Have reverted to a basic hass built in fan button and it is working (obviously I need to open the submenu to adjust speed however).

Avatar1976 commented 2 years ago

image Fan attributes here

Avatar1976 commented 2 years ago

image

perezrojose commented 2 years ago

What hassio version do you have installed? I got the same error after updating to version 2022.04

chronitale commented 2 years ago

I have same issue. Home Assistant OS 7.6 supervisor-2022.03.5

Avatar1976 commented 2 years ago

What hassio version do you have installed? I got the same error after updating to version 2022.04

As per above @chronitale and @perezrojose Yep OS 7.6, Core 2022.4.1, Supervisor 2022.03.5

knucklebust0 commented 2 years ago

I have the same issue. it started after the update as well.

Avatar1976 commented 2 years ago

Also broken on newest core-2022.4.2 And Supervisor 2022.4

altserg commented 2 years ago

I confirm that it does not work on core-2022.4.2 also in my case. See the picture below. The visualization is inconsistent with the actual state, cannot slide anymore image

Probably the cause is breaking change in HASS 2022.4.2: https://github.com/home-assistant/core/pull/67743

I think that one of the problems is that deprecated speed attribute is used in file src/fan-controller.ts. It should be replaced with 'percentage' attribute: image

But I have no clue how to recompile the frontend card, I'm more a backend person

Avatar1976 commented 2 years ago

@mattieha any chance of a workaround to get your card working again with fans (of the spinning variety and the fanatic variety)? ;)

DannyN2222 commented 2 years ago

Ive had the same issue too after the first april core update, was working before the update, no changes to config and then stopped working immediatly after the update the only part of this that still works if turning the fan off and on (changing the speed or viewing the speed is broken) im am using a ESPhome Speed Fan component for this

AaronAutomation commented 2 years ago

Same issue for me. Upgraded Core to 2022.4.1 and slider no longer functional. I can toggle on/off or go to More Info to adjust speed but it either shows 100% or 0%.

rohankapoorcom commented 2 years ago

I added a PR that will fix the issue (#185). Until it is merged and released, I'm using my own fork at https://github.com/rohankapoorcom/slider-button-card that you can install in HACS which will work with Home Assistant Core 2022.4 and higher.

altserg commented 2 years ago

I added a PR that will fix the issue (#185). Until it is merged and released, I'm using my own fork at https://github.com/rohankapoorcom/slider-button-card that you can install in HACS which will work with Home Assistant Core 2022.4 and higher.

Shall I use the .js file in https://github.com/rohankapoorcom/slider-button-card/tree/main/dist ? Was it updated ?

rohankapoorcom commented 2 years ago

You can use the one attached to this release: https://github.com/rohankapoorcom/slider-button-card/releases/latest

Naro90029 commented 2 years ago

I got the same issue so I started using this one until it gets fixed. https://github.com/thomasloven/lovelace-slider-entity-row

Avatar1976 commented 2 years ago

I added a PR that will fix the issue (#185). Until it is merged and released, I'm using my own fork at https://github.com/rohankapoorcom/slider-button-card that you can install in HACS which will work with Home Assistant Core 2022.4 and higher.

10/10 do recommend, works great thanks Rohan. @mattieha please commit @rohankapoorcom 's pull request.

paultbarrett commented 2 years ago

I added a PR that will fix the issue (#185). Until it is merged and released, I'm using my own fork at https://github.com/rohankapoorcom/slider-button-card that you can install in HACS which will work with Home Assistant Core 2022.4 and higher.

Confirmed that this has resolved the problem. Using this repo for now until the pull is committed

amitsamanta996 commented 2 years ago

TEMPORARY WORKING FIX BEFORE DEVS UPDATE THE MODULE in file manager go to location /config/www/community/slider-button-card/ Download the js file, Delete the gz file. Edit the js file and search for "speed" and replace with "percentage"

before: get hasSlider(){return"speed"in this.stateObj.attributes} after: get hasSlider(){return"percentage"in this.stateObj.attributes}

make a gz file of the js file using 7-Zip upload the js file and gz file in that folder

go to configuration -> dashboard -> resources edit the js file location and add some character after the hacstag=some number, so that you don't have to clear the cache on every device.

Reload page, all fan percentage working now. thanks to @rohankapoorcom for the fix

rohankapoorcom commented 2 years ago

@amitsamanta996 - I would instead just grab the .gz file from the releases page on my fork. That's even easier than applying the change manually yourself.

DannyN2222 commented 2 years ago

as much as id hate this to be the case, the last commit to this was 6 months ago (27th nov 2021) and this bug has been well documented as being a really simple fix, that also the HA devs announced was happening some time ago id advise people use rohankapoorcom's version as he is update his quite regually (last commit: yesterday) and seems to also be adding new features to it based on this fact (otherwise why would there be commits after its already fixed?)

also since he seems to be active here, ty for fixing the issue :)

altserg commented 2 years ago

hm... still have not managed to get the fix working... Cleaned up cache, etc.... I have 2 fans, but none of them work, any suggestions ? image

DannyN2222 commented 2 years ago

EDIT: before you do anything read till the end, due to being lazy i put a trick to save time you need to do first at the end (makes perfect sence i know)

TBF same for me at first it just wants to add this brocken one each time, so i added it as a custom repository to do this on HACS go onto the frontend page, click the 3 dots in the top right on the menu that appears click 'custom repositories' (should be 2nd from bottom) then put the link to the github page in the URL field (so https://github.com/mattieha/slider-button-card so this one and https://github.com/rohankapoorcom/slider-button-card for the fixed one) and 'lovelace' for category, that worked for me, although i deleted the old slider card before doing this so that HA would call it the exact same name as the old card, this means i didn't have to update any of my dashboard, they just started working after i refreshed the page (exactly like how they broke)

altserg commented 2 years ago

Started to work after some magic... My prayers for front end developers who have to battle this type of s....t every day

danleongjy commented 2 years ago

Thanks @rohankapoorcom, your fork is working well for me. Hope that your PR will be accepted soon!

spudje commented 2 years ago

Still no update for this. Guess I'll have to move to other repo as well :(

rohankapoorcom commented 2 years ago

Hi all - I've reached out a couple of times to @mattieha to see if we could get some things moving but they are non responsive.

I've been working behind the scenes with @lizsugar to create a new canonical fork that we will co-maintain going forward. The new repo is located at https://github.com/custom-cards/slider-button-card.

Please post new issues and PRs there and we'll work through them as soon as possible.

We are working to get the new fork included as the default in HACS: https://github.com/hacs/default/pull/1388