search

mattjbray / ocaml-decoders

Elm-inspired decoders for Ocaml
https://mattjbray.github.io/ocaml-decoders/
Other
84 stars 8 forks source link

Jsonaf #50

Closed dvmitrv closed 2 years ago

dvmitrv commented 2 years ago

Hello!

I've added a Decoders_jsonaf module for janestreet/jsonaf.

Regarding tests, I was rather lazy and just took yojson_basic_suite and adapted it for jsonaf. I've credited @mattjbray for this, hope it's okay!

mattjbray commented 2 years ago

Looks great! Just need to figure out how to skip the 4.08 build for this package.

mattjbray commented 2 years ago

Can you rebase this on master and then add decoders-jsonaf to the package matrix: https://github.com/mattjbray/ocaml-decoders/blob/22a7856c1ee406aaf17fe6941fa46f65319677c7/.github/workflows/build.yml#L20-L28

mattjbray commented 2 years ago

I'm working on a fix in #52

mattjbray commented 2 years ago

Ok #52 is merged, if you rebase again hopefully it'll pass this time 🤞

mattjbray commented 2 years ago

Thanks!

dvmitrv commented 2 years ago

Thank you for the quick process!