search

mattjegan / django-gamification

The missing Django Gamification Package
Other
166 stars 28 forks source link

Plan out notification features #5

Open mattjegan opened 7 years ago

clintonb commented 7 years ago

A mistake that some apps make is that they do too much. I want a badging library, not a badging and notifications library. Odds are my rules for notifications (e.g. timing, unsubscribed users) are different than yours. Same goes for my methods of notification (e.g. email, push).

Instead of sending an email/alert, fire a signal when a badge is awarded. Such a signal would probably be the same as Django's existing save signal, but there may be some value in providing a custom name (e.g. badge.awarded) for future expansion.

mattjegan commented 7 years ago

Thanks @clintonb for the input, definitely something to have a think about. I think the signal route very well might be the way to go with this 😄