mattjennings / mdsvexamples

Render your Svelte code blocks in MDSveX
31 stars 2 forks source link

Update dependency to vite 4.0.0 #20

Closed shinokada closed 1 year ago

shinokada commented 1 year ago

When I update vite to 4.0.0, I get an warning:

 WARN  Issues with peer dependencies found
.
└─┬ mdsvexamples 0.3.2
  └─┬ unplugin 0.7.2
    └── ✕ unmet peer vite@"^2.3.0 || ^3.0.0-0": found 4.0.0

Can you update to vite 4.0.0?

mattjennings commented 1 year ago

can you try v0.3.3? https://github.com/mattjennings/mdsvexamples/releases/tag/0.3.3

shinokada commented 1 year ago

v0.3.3 has "vite": "^3.0.0". As far as I know, It works with vite 4.0.0. Are there any concerns that it won't work with vite 4.0.0?

mattjennings commented 1 year ago

No. The peer dependency warning came from unplugin, which I updated and doesn’t seem to have vite as a peer dep anymore.

If you’re not getting the peer dep warning with v0.3.3 then everything is good and I’ll close this issue.

On Sat, Dec 10, 2022, at 2:20 AM, Shinichi Okada wrote:

v0.3.3 has "vite": "^3.0.0". As far as I know, It works with vite 4.0.0. Are there any concerns that it won't work with vite 4.0.0?

— Reply to this email directly, view it on GitHub https://github.com/mattjennings/mdsvexamples/issues/20#issuecomment-1345183079, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCMY4U32ABEHCY5QQTFRZ3WMQ4NZANCNFSM6AAAAAASZ5IMHM. You are receiving this because you commented.Message ID: @.***>

shinokada commented 1 year ago

Then can you update package.json?

mattjennings commented 1 year ago

It is a devDependency. It is not used when you install it.

Closing this as it is fixed, no peer dependency warning is shown anymore when installing in Vite 4 projects.

On Sat, Dec 10, 2022, at 3:04 AM, Shinichi Okada wrote:

Then can you update package.json?

— Reply to this email directly, view it on GitHub https://github.com/mattjennings/mdsvexamples/issues/20#issuecomment-1345190911, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCMY4R7Z2XSR2HJNPHRDHTWMRBRTANCNFSM6AAAAAASZ5IMHM. You are receiving this because you commented.Message ID: @.***>