search

mattjennings / svelte-pixi

Create PixiJS apps with Svelte
https://svelte-pixi.com
MIT License
119 stars 15 forks source link

Remove track property on unmnount #14

Closed dmitriyzhirma closed 2 years ago

dmitriyzhirma commented 2 years ago

fn not removed from ticker if not pass context arg as pixi ticker require context with priority

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svelte-pixi ❌ Failed (Inspect) May 26, 2022 at 1:39PM (UTC)
mattjennings commented 2 years ago

hey @dmitriyzhirma , can you update this PR so that the commit message follows conventional commits? Basically just needs to be fix: <msg> (this helps me generate changelogs and release versions)

You can do git reset HEAD~ to undo the commit and then re-commit it, and then git push --force.

As for the failed Svelte Check & Prettier checks, if you pull the latest changes from master those should be fixed now.

dmitriyzhirma commented 2 years ago

done

mattjennings commented 2 years ago

thanks!