search

mattjj / pyhsmm

MIT License
546 stars 173 forks source link

move `deps/` to package root #37

Closed mattjj closed 9 years ago

mattjj commented 9 years ago

Should deps/ (namely Eigen) be moved from inside the pyhsmm subdirectory to the package root?

yarden commented 9 years ago

Yes, I can take care of this. I didn't do it before because I wasn't sure if deps/ might be a place for Cython code dependency in future. If it's purely for external C/C++ libraries then it definitely shouldn't be a subdir of pyhsmm subdir because it's not part of the Python package.

I'll also try to add travis support. I've been looking for an excuse to learn travis and now I have one.

yarden commented 9 years ago

This is now taken care of in: https://github.com/mattjj/pyhsmm/pull/39