search

mattjohnsonpint / TimeZoneNames

Provides a complete source of localized time zone names and abbreviations.
MIT License
196 stars 32 forks source link

Issue #18 Provide public constructor to allow protobuf-net access in … #19

Closed dlgreenwell closed 6 years ago

dlgreenwell commented 7 years ago

PR to allow for Silverlight to use TimeZoneNames without elevated trust.

From the protobuf-net documentation-

Notes on types

supported:

custom classes that: are marked as data-contract have a parameterless constructor for Silverlight: are public many common primitives etc single dimension arrays: T[] List / IList Dictionary / IDictionary any type which implements IEnumerable and has an Add(T) method The code assumes that types will be mutable around the elected members. Accordingly, custom structs are not supported, since they should be immutable.

mattjohnsonpint commented 7 years ago

Hey, thanks for this. It may take me some time before I can fully digest it, but also may just try to finally get rid of the protobuf dependency. It's an unnecessary crutch for this library's purposes really.

dlgreenwell commented 7 years ago

That's totally fine. For the time being, I made the change locally and have published it to our in house nuget server. I will check back periodically to see what you end up doing with it.

troygrosfield commented 7 years ago

@mj1856 any updates on this?

mattjohnsonpint commented 6 years ago

Just released 3.0.0 for .NET Standard support and removal of protobuf. Thus, this is no longer applicable. Thanks.