search

mattjohnsonpint / TimeZoneNames

Provides a complete source of localized time zone names and abbreviations.
MIT License
196 stars 32 forks source link

Netstandard support #21

Closed jarroda closed 6 years ago

jarroda commented 7 years ago

I hate to be 'that guy' on your repo... but do you plan on supporting .netstandard as a build target for this library? Looks like protobuf has support for it, so hopefully it would be a fairly easy port.

mattjohnsonpint commented 7 years ago

I do. I just haven't gotten to it yet. And I want to drop the protobuf dependency first.

jarroda commented 7 years ago

Sounds great. In the meantime, I would really like to use your project for a .net core app we are building, so I nearly have your project ported to netstandard. I have the main TimeZoneNames project and the DataBuilder projects completely converted and working xplat, and I regenerated the tz.dat successfully on OSX as a test. I still plan on porting the testing project.

If you are interested in these changes, I would be happy to send you a PR. If not, we will just use my fork for now and will switch back to your package when you have made your changes.

DDN-Shep commented 7 years ago

Looking forward to this too as I need it for .NET Core project.

This sort of library is surprisingly quite rare despite how many people want a time zone abbreviation!

sirishs commented 7 years ago

I am on the other side of the boat, I want to use with regular .net45+ framework without .net core, so it will be great if we can get rid of protobuf dependency as mj called out earlier and publish a version without that, then I will be able to consume this package.

Currently I am getting a runtime exception stating: 'blah... Could not load file or assembly 'System.Core, Version=2.0.5.0... blah'

Yes, it is surprising that this is only nuget package which has this wonderful timezone localization feature. :) Thanks for this amazing package!

mattjohnsonpint commented 7 years ago

Thanks for the feedback. Yes, will do. Just been busy. Thanks for being patient. :)

mattjohnsonpint commented 6 years ago

Done with 3.0.0. Thanks.