search

mattjohnsonpint / TimeZoneNames

Provides a complete source of localized time zone names and abbreviations.
MIT License
196 stars 32 forks source link

Dependency on Newtonsoft.Json #30

Closed jnyrup closed 6 years ago

jnyrup commented 6 years ago

I see that the new version depends on Newtonsoft.Json v10.0.3. Is that version picked, because that's the version the DataExtractor uses, or does TimeZoneData also need v10.0.3/newest to deserialize the data again?

mattjohnsonpint commented 6 years ago

It does need to be used on both sides, yes. I had just picked the most current version when I installed, but I can probably relax that a bit. I'll post an update shortly, lowering the version requirement to the minimum supported. Thanks.

mattjohnsonpint commented 6 years ago

Ok. I lowered the Newtonsoft.Json dependency to >=5.0.5 for .NET Framework and to >=9.0.1 for .NET Standard.

Released as version 3.1.0. https://www.nuget.org/packages/TimeZoneNames/3.1.0

jnyrup commented 6 years ago

Maybe a silly question, but have you deployed the right build to NuGet? On https://www.nuget.org/packages/TimeZoneNames/3.1.0 it says that .netstandard 1.1 has a dependency on newtonsoft 6.0.2. It's the same in the nuspec when downloading the nupkg. Shouldn't it be v9.0.1 as per b43d692a3cb685a228dbe6dfccbc345561fa24ec

jnyrup commented 6 years ago

@mj1856 Just to verify: I just created .netstandard1.1 project and tried to install TimeZoneNames 3.1.0, but it failed with: Package Newtonsoft.Json 6.0.2 is not compatible with netstandard1.1 (.NETStandard,Version=v1.1).

mattjohnsonpint commented 6 years ago

Yeah, I must have screwed up something. Republished as 3.1.1. Looks good now I think.