Closed dzeitlin closed 2 years ago
checked TimeZoneConverter::DataLoader.Populate()
looks good and uses fully qualified resource names in calling to GetEmbeddedData()
Thanks. Your proposal sounds reasonable. I'll fix that in the next release. Thanks.
in TimeZoneData.Load() instead
using Stream compressedStream = assembly.GetManifestResourceStream($"{assembly.GetName().Name}.data.json.gz");
please use explicit resource name like thisusing Stream compressedStream = assembly.GetManifestResourceStream("TimeZoneNames.data.json.gz");
since if one ILmerge your package into
some_assemble.dll
, the resource name still must beTimeZoneNames.data.json.gz
and notsome_assemble.data.json.gz
TimeZoneNames v2.0.1 loaded data like this and it worked fine after ILmerge.
using Stream stream = typeof(TimeZoneData).Assembly.GetManifestResourceStream("TimeZoneNames.tz.dat");