search

mattkjames7 / PyGeopack

Wrapper for geopack-08 used for the Tsyganenko magnetic field models
GNU General Public License v3.0
11 stars 2 forks source link

Ver win64 #10

Closed pshustov closed 2 years ago

pshustov commented 2 years ago

There are few commits. I little change C and Fortran source to accommodate the compiler warnings. And add auto recompile script with precompiled dll library, just like in PyDateTimeTools. It is assumed that compatibility with Linux is preserved, but this should be tested.

Everything tested and works well in Windows 10.

mattkjames7 commented 2 years ago

Wow, you have put a lot of work into these pull requests! Thanks for your help on this. It might take me a little time to work my way through these changes to check that they still work in Linux (I'm off work this week unfortunately too!). Great stuff!

pshustov commented 2 years ago

I will be glad to help with this project! Be at your own pace, there is really a lot of code to check)

pshustov commented 2 years ago

Just found a strange feature of installing a package via pip that I can't figure out. If I install the package by the command, e.g.: pip install git+https://github.com/mattkjames7/PyGeopack, then some download files don't match files in git. For example, there is no TraceDir arg in TraceField function in TraceRoutine. I expect the files to be installed directly from the github, but it looks like pip just ignore your commit where trace direction were added, or smth. If I use editable mode pip install -e git+https://github.com/mattkjames7/PyGeopack#egg=PyGeopack everything is ok.

And this behaver keeps in my fork. It leads to some problems with pip installing. The files that I changed now get the changes from your previously ignored commit. But files which I haven't changed, still ignore it. Editable mode work just as expected.

So, do you understand why this is occur?

mattkjames7 commented 2 years ago

Just found a strange feature of installing a package via pip that I can't figure out. If I install the package by the command, e.g.: pip install git+https://github.com/mattkjames7/PyGeopack, then some download files don't match files in git. For example, there is no TraceDir arg in TraceField function in TraceRoutine. I expect the files to be installed directly from the github, but it looks like pip just ignore your commit where trace direction were added, or smth. If I use editable mode pip install -e git+https://github.com/mattkjames7/PyGeopack#egg=PyGeopack everything is ok.

And this behaver keeps in my fork. It leads to some problems with pip installing. The files that I changed now get the changes from your previously ignored commit. But files which I haven't changed, still ignore it. Editable mode work just as expected.

So, do you understand why this is occur?

Sorry, I missed this. I can't say I have had any problems with installing this using pip, are you able to build a wheel file for it and install using that?

I am just making some fixes to the pyomnidata package, then I will attempt to merge your PyGeopack code with my latest branch. Hopefully that will fix any problems!