search

mattkrick / cashay

:moneybag: Relay for the rest of us :moneybag:
MIT License
453 stars 28 forks source link

Move babel-runtime to dependencies #137

Closed dustinfarris closed 7 years ago

dustinfarris commented 7 years ago

babel-runtime seems to be needed in user-space here. Otherwise I am getting errors e.g.:

Cannot find module 'babel-runtime/core-js/object/keys'
Error: Cannot find module 'babel-runtime/core-js/object/keys'
    at Function.Module._resolveFilename (module.js:472:15)
    at Function.Module._load (module.js:420:25)
    at Module.require (module.js:500:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/dustin/Test/my-app/node_modules/cashay/lib/normalize/mergeStores.js:7:13)
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 76.923% when pulling ef6e382e1b8a7ca70af50418b4eb71f0467d495c on dustinfarris:fix-dep into 52f7f58876a22186de9dcd737081fe7573788db0 on mattkrick:master.

dustinfarris commented 7 years ago

Possible reason this is showing up for me:

I am using graphql 0.7.x. Cashay pegs graphql 0.6.0

In graphql 0.6.1, graphql dropped its own babel-runtime dependency, however cashay still needs babel-runtime itself.

See graphql/graphql-js#414 for more context on their decision to drop the dependency.

dustinfarris commented 7 years ago

I think the right way forward is to drop babel-runtime altogether. I will open a new issue.

dustinfarris commented 7 years ago

See #138