I found a problem while trying to query something containing a floor in a very basic form. Floor is expected to be a non null Int but very often equals 0. I found out that the falsy values are not handled in
getMissingRequiredVariables. This PR solves the problem by specifically looking for null or undefined.
Edit: coverage decreases because the queryHelpers.js file was not in the tests percentage before and I only test one of the few functions of the file
Coverage decreased (-4.01%) to 72.388% when pulling 1d972080ed67d2e301df8916b9f2e06a13e8a39f on theobat:master into da2e138fc44ea7ff6bec5cec56ab1e141b417751 on mattkrick:master.
Hi @mattkrick,
I found a problem while trying to query something containing a floor in a very basic form. Floor is expected to be a non null Int but very often equals 0. I found out that the falsy values are not handled in getMissingRequiredVariables. This PR solves the problem by specifically looking for null or undefined.
Edit: coverage decreases because the queryHelpers.js file was not in the tests percentage before and I only test one of the few functions of the file