search

mattkrick / cashay

:moneybag: Relay for the rest of us :moneybag:
MIT License
453 stars 28 forks source link

Mutation invalidation #166

Open theobat opened 7 years ago

theobat commented 7 years ago

@mattkrick

These are mostly test cases for the Cashay class. A small yet required fix is in Cashay.js about the _invalidation method passed as an argument to the mutationHandlers. This method cannot modify the global since it's tied to 'this' and 'this' is undefined when the method is called from outside the instance of Cashay (which is the case since it can be called from a mutationHandler).

Let me know if formatting or anything else is needed More tests are coming

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-6.3%) to 70.13% when pulling 0d75943994a2a48a60122be94593c6a6890d58be on theobat:mutation-invalidation into da2e138fc44ea7ff6bec5cec56ab1e141b417751 on mattkrick:master.