search

mattkrick / meatier

:hamburger: like meteor, but meatier :hamburger:
3.05k stars 173 forks source link

use a shared eslint config #137

Closed wenzowski closed 8 years ago

wenzowski commented 8 years ago

This allows the xo config to be shared with eslint, enabling any ide with eslint support to render syntax errors inline. I've got eslint running in vim using syntastic and this is now working beautifully there.

wenzowski commented 8 years ago

Oh, and @mattkrick you have commit on eslint-config-xo-meatier. Pushing tags there auto publishes to npm via travis.

mattkrick commented 8 years ago

oh that's amazing, thank you! Also, if there are any rules you don't agree with please feel free to change em, I'm not married to any of em. I'm still waiting for the day that JS has a PEP8 equivalent & we can all write code the same way...

Just 1 question about the changed regex... I'm not sure if you fixed it or if it was a wild keystroke. After that gets cleared up this looks good to merge!

wenzowski commented 8 years ago

Yes intentional. Did a s/\\#/#/ to silence no-useless-escape. See answer on commit.

wenzowski commented 8 years ago

Regarding linter configuration, my strong preference is to use one in every published project to help avoid painting the bikeshed by encouraging committers to consider a project-consistent style prior to submitting patches on it.