mattkwan-zz / android-xserver

Automatically exported from code.google.com/p/android-xserver
61 stars 49 forks source link

xfe does not display icons correctly #14

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. start android-xserver
2. start xfe with display directed at android xserver

What is the expected output? What do you see instead?

Display mostly correct but greyed-out icons missing.
Multiple errors reported to xfe console... BadLength (poly request too large or 
internal Xlib length error)

What version of the product are you using? On what operating system?
xfe running on ubuntu 12.04.
android-xserver 1.11 running on nexus 7.

Please provide any additional information below.

Greyed out icons seem to be delivered as format 2 (zpixmap) images with a depth 
of 1... but the image is delivered as a series of nibbles. Not so far found 
good documentation on why this happens.

The images are then delivered to the display using copyPlane which wasn't 
working due to the colour selection code... The original images were created 
with fg and bg colours which were at the time both white.

Attached is a version of Drawable.java which some changes to...

processPutImage
---------------
Check for nibble format images
Write images with black and white pixels

copyPlane
---------
Use translucent as background
Use foreground for white pixels

Changes are not rigorous but do correct display issues for xfe. It is of course 
possible suggested changes damage display of other applications.

Original issue reported on code.google.com by pmsc...@gmail.com on 1 Oct 2012 at 6:23

Attachments: