search

mattlewis92 / angular-bootstrap-calendar

A port of the bootstrap calendar widget to AngularJS (no jQuery required!)
https://mattlewis92.github.io/angular-bootstrap-calendar/
MIT License
798 stars 367 forks source link

Big amount of events make it slow #32

Closed freefri closed 9 years ago

freefri commented 9 years ago

I have tried angular-bootstrap-calendar, it looked awesome in the demo, but when I have implemented it in my application I realize it got terrible slow when I have a big amount of events. For example, over 100 events I feel some seconds of delay when switching from year to month calendar, and over 300 events the browser says the script stops responding. Maybe I have done something wrong in my implementation, but I've added 20 events into the live demo (http://mattlewis92.github.io/angular-bootstrap-calendar/) and I already fill some miliseconds of delay between switching.

The problem seems to occur during updateView() function.

mattlewis92 commented 9 years ago

I've never tried it with that many events before, there's some easy performance improvements I can make though which should sort it out.

PatrickRansom commented 9 years ago

I'd be very interested in any improvements in speed as well. I am in the process of implementing but imagine I'll have quite a few events.

mattlewis92 commented 9 years ago

I've just put in a few performance improvements, however the majority of the lag isn't caused by the calendar itself though, it's actually the demo table of events, if you remove the event editor from the demo I successfully added 1000 events to the calendar with no noticeable lag.

freefri commented 9 years ago

Awesome, I have tested now my proyect with the new code and I really feel the difference. I am working with month view, with arround 250 events in that month, before it was hanging some times and now I just notice a small aceptable lag

mattlewis92 commented 9 years ago

Great to hear! :)

PatrickRansom commented 9 years ago

Thanks for the updated code. Implementing now. Indeed it appears it's the editor that's slowing things down. Much appreciated!

Patrick Ransom

On Mar 21, 2015, at 2:30 PM, Matt Lewis notifications@github.com wrote:

I've just put in a few performance improvements, however the majority of the lag isn't caused by the calendar itself though, it's actually the demo table of events, if you remove the event editor from the demo I successfully added 1000 events to the calendar with no noticeable lag.

— Reply to this email directly or view it on GitHub.