search

mattlewis92 / angular-bootstrap-calendar

A port of the bootstrap calendar widget to AngularJS (no jQuery required!)
https://mattlewis92.github.io/angular-bootstrap-calendar/
MIT License
798 stars 369 forks source link

Dragging event also fires range selection #614

Closed trks1970 closed 7 years ago

trks1970 commented 7 years ago

When dragging an event forward (eg: to a date after the current date in month view) on-date-range-select and on-event-times-changed are both invoked. Is there a possibility to distinguish if range selection occured because of a drag or without an event being dragged?

burtek commented 7 years ago

First of all - @mattlewis92, should on-date-range-select really be invoked in this case?

trks1970 commented 7 years ago

No, that would of course be the preferred case. It should only be invoked, without a drag.

mattlewis92 commented 7 years ago

This does look like a bug, the date range select simply shouldn't be invoked when dragging an event. Plunker: http://plnkr.co/edit/ykLjQN0uXyGBPBU16E6o?p=preview

mattlewis92 commented 7 years ago

I've just cut 0.29.3 which should fix this, LMK if it works for you 😄

trks1970 commented 7 years ago

Aye, it does work. Thanks for the quick fix.

mattlewis92 commented 7 years ago

That's great to hear! 😀