search

mattlewis92 / angular-bootstrap-calendar

A port of the bootstrap calendar widget to AngularJS (no jQuery required!)
https://mattlewis92.github.io/angular-bootstrap-calendar/
MIT License
798 stars 369 forks source link

fix(dayView): expose the overlap option in interact #651

Closed bwobbones closed 6 years ago

bwobbones commented 7 years ago

Part of an overall change to allow manual resizing of hour-parts (broken out from #620).

Exposes the "overlap" option within interact. I needed to do this because there is a conflict when the dropzone window and the hour part windows are exactly the same size that requires the 'center' value to be used. The 'pointer' value is retained as the default.

codecov-io commented 7 years ago

Codecov Report

Merging #651 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #651      +/-   ##
========================================
+ Coverage   95.99%    96%   +<.01%     
========================================
  Files          26     26              
  Lines         724    725       +1     
========================================
+ Hits          695    696       +1     
  Misses         29     29
Impacted Files Coverage Δ
src/directives/mwlDroppable.js 93.75% <100%> (+0.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21118e5...b29dab1. Read the comment docs.

bwobbones commented 6 years ago

@mattlewis92 got time to look at this and #652?

mattlewis92 commented 6 years ago

Oops, sorry I don't have too much time for open source nowadays, please can you make this a new option instead of using the mwlDroppable attribute (something like dropOverlap instead?) Otherwise LGTM, thanks for your contribution!