mattlewis92 / angular-calendar

A flexible calendar component for angular 15.0+ that can display events on a month, week or day view.
https://mattlewis92.github.io/angular-calendar/
MIT License
2.73k stars 868 forks source link

fix(month-view): add missing a11y attributes #1498

Closed Arhum24 closed 3 years ago

Arhum24 commented 3 years ago

Changes to angular-calendar for better accessibility as the "American Disability Act" becomes mainstream and other developers may or may not have to comply with it as well in the future.

Changes to "Month" view so that a screen reader i.e. NVDA, Talkback, or Voiceover would speak the number of rows and columns for days present in a grid.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1498 (eff3bf4) into master (5fc9ef7) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1498   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          39       39           
  Lines         751      751           
  Branches      126      126           
=======================================
  Hits          720      720           
  Misses          1        1           
  Partials       30       30           
Impacted Files Coverage Δ
...src/modules/month/calendar-month-view.component.ts 90.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5fc9ef7...eff3bf4. Read the comment docs.

mattlewis92 commented 3 years ago

Released as 0.28.27! 🥳