mattlewis92 / angular-calendar

A flexible calendar component for angular 15.0+ that can display events on a month, week or day view.

https://mattlewis92.github.io/angular-calendar/

MIT License

2.72k stars 863 forks source link

feat(foregroundColor): add foreground color to events #1579

Closed angelaki closed 2 years ago

angelaki commented 2 years ago

Since the color is pretty hard to read on some users backgrounds I'd love to set the color easily (not needing to use classes).

angelaki commented 2 years ago

Hey @mattlewis92, how about merging this tiny neat PR? :)

mattlewis92 commented 2 years ago

Hey @mattlewis92, how about merging this tiny neat PR? :)

Sorry about the late reply, I missed the notification. I have some thoughts on the naming, let me know what you think!

angelaki commented 2 years ago

Yeah, liked the idea of secondaryText. And yes, called secondary because it's only the text color on the secondary background (dayview). Also changed the interfaces' properties (https://github.com/mattlewis92/calendar-utils/pull/50).

angelaki commented 2 years ago

Hey, how about my PR? Ready to merge? ;)

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (0.30.0@15be922). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head bb50666 differs from pull request most recent head 547794b. Consider uploading reports for the commit 547794b to get more accurate results

@@            Coverage Diff            @@
##             0.30.0    #1579   +/-   ##
=========================================
  Coverage          ?   95.00%           
=========================================
  Files             ?       39           
  Lines             ?      680           
  Branches          ?      143           
=========================================
  Hits              ?      646           
  Misses            ?        1           
  Partials          ?       33

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mattlewis92 commented 2 years ago

Added here! https://github.com/mattlewis92/angular-calendar/pull/1594/commits/53e80a6054a0f09524c1f64b0fde9d5b0d7b2cdd Will release to npm shortly 😄

Thanks for your contribution and patience with getting this released! 🙌