search

mattlewis92 / angular-calendar

A flexible calendar component for angular 15.0+ that can display events on a month, week or day view.
https://mattlewis-github.com/angular-calendar/
MIT License
2.71k stars 863 forks source link

Documentation of minimumEventHeight in week view is incorrect #1666

Open mkroeders opened 1 year ago

mkroeders commented 1 year ago

Describe the bug

The documentation of minimumEventHeight in the week view says it is the height in pixels. However it should be in minutes.

Or if it should be pixels than the getTimeEventResizedDates method uses it as minutes on line 1.348.

Minimal reproduction of the problem with instructions

When using it as pixels, when they are not the same as the minute size resizing goes wrong

Versions

angular calendar 0.31.0

matts-bot[bot] commented 1 year ago

Thanks so much for opening an issue! If you'd like to support this project, then please consider sponsoring me

billyjov commented 9 months ago

@mkroeders can you pls provide a stackblitz reproduction of the issue?

mkroeders commented 9 months ago

this.dateAdapter.addMinutes( newEventDates.end, this.minimumEventHeight * -1 )

@billyjov not sure how to stackblitz this. But if you look at line 1348 of CalendarWeekViewComponent you see it is used in a minute context. While the docs say it is in pixels