Authentication, Type/Value checks, Use of News API error messages, and addressed a Windows cmd error

bantaisaiah commented 6 years ago

I added Type/Value Error messages to the optional variables in all functions, checking an additional file that has all variables and base URLs.
Added error catching for the top_headlines function according to the defined constraints laid out on the News API website: https://newsapi.org/docs/endpoints/top-headlines

Note: you can't mix this param with the country or category params.
Changed the name of the to parameter to to_param in order to be consistent with from_param
Added format check, with appropriate error message, to the to_param and from_param values
Added value checks to ints related to page parameters
Added Error code message to requests made which is provided by News API under their Errors section: https://newsapi.org/docs/errors
Updated README.md with an error that is produced when attempting to print the .json() object to the command line, and how to circumvent it in a healthy way with attached information as to the reasons why

mattlisiv commented 6 years ago

Hi @banta-isaiah ,

Thanks for the update. I really like the way these type checks are handled with the library.

A few things I think need to be adjusted:

You have a typo in a few error statements where the flag is 'raist' rather than 'raise'
On line 211, it should be:

if language not in const.languages:

rather than containing a 'is' .

For now, let's keep the parameter as 'to' rather than 'to_param' . I definitely think it is better naming convention, but I don't want to worry about breaking anyone's app with a version upgrade or updating the documentation on newsapi.org without a CHANGELOG in place.

Thanks!

bantaisaiah commented 6 years ago

Done! Let me know if there is anything else you see an issue with

mattlisiv commented 6 years ago

@banta-isaiah, it looks like you still have the to_param set as an argument within the function (line 121) .

def get_everything(self, q=None, sources=None, domains=None, from_param=None, to_param=None, language=None

Once that is corrected, everything looks good!

mattlisiv / newsapi-python