search

mattlisiv / newsapi-python

A Python Client for News API
MIT License
376 stars 130 forks source link

Enum field checking #8

Closed TomFaulkner closed 6 years ago

TomFaulkner commented 6 years ago

Some of the fields have a limited set of strings that are acceptable, such as category, country, or language. It would probably be more user friendly if these were checked for validity before being passed to the API.

Enums would also be possible, though that could make for more work on the library user depending on how they are writing their code, and could also be a breaking change.

bantaisaiah commented 6 years ago

Can this issue be closed since I addressed it with my PR?

mattlisiv commented 6 years ago

That is correct. Closing. Thanks!