search

mattlockyer / composables-998

An implementation and documentation repo for developing the ERC-998 standard for Ethereum.
MIT License
103 stars 64 forks source link

Numerous changes #13

Closed mudgen closed 6 years ago

mudgen commented 6 years ago

Here are the changes in this pull:

  1. Changed the interface names to match the standard they are for.
  2. Added isApprovedOrOwnerOf function to ERC998ERC721 interface.
  3. Renamed the ERC20 related functions to make them specific to the standard they are related to.
  4. I moved the composable functionality into Composable.sol. This was done because both ERC20 tokens and ERC721 tokens need to share functionality, specifically the isApprovedOrOwnerOf function. It is still possible for implementors to only implement individual interfaces.
  5. The ERC721 standard changed to include an additional operator argument to onERC721Received so this was changed in this pull.