search

mattlockyer / composables-998

An implementation and documentation repo for developing the ERC-998 standard for Ethereum.
MIT License
103 stars 64 forks source link

Improving ERC998PossessERC721 #6

Closed mudgen closed 6 years ago

mudgen commented 6 years ago
  1. I renamed childOwnerOf to ownerOfChild.
  2. I removed the _tokenId argument from the childTransfer functions because it is not needed.
  3. I added ERC721Token to ERC998PossessERC721 so that the childTransfer functions can use isApprovedOrOwner(msg.sender, tokenId) for ownership and approval checks.
  4. I added the _childContract argument to the TransferChild event.
  5. I started using truffle with this project and updated the tests with the changes made in this pull request so the tests won't break. I commented out for now tests that were breaking from before.

Note: We need to change the transferChildToComposable function because calling ERC998NFT(_to).onERC721Received(this, _childTokenId, _data); does not work though it appears to. The problem is that onERC721Received adds in an additional indirect argument which is msg.sender, which has the wrong value if called directly from the ERC998PossessERC721 contract. We use msg.sender in onERC721Received to know what the childContract is. I can work on this tomorrow.