search

mattloper / chumpy

MIT License
195 stars 118 forks source link

Fix CircleCI config and test in Python 3 #35

Closed paulmelnikow closed 4 years ago

paulmelnikow commented 4 years ago

Hey Matt! Thanks for merging my PRs 😁

My bad on this config I added in #27. Looks like I had truncated it by mistake. Here's the correct config from the fork.

Added: For this to build, it looks like you'll have to configure Circle to "build forked pull requests."

paulmelnikow commented 4 years ago

Looks like it did run: https://circleci.com/workflow-run/9968e9f0-aafc-4dd3-be3d-22d7d3e6d3bd

Status hasn't showed up here, though it started showing up in #36 so maybe it's working now.

paulmelnikow commented 4 years ago

Hey @mattloper it'd be great to have a working CI setup for this repo. Could you merge this? There are also a few niceties in #36 which it'd be great to have shipped. Thanks!

paulmelnikow commented 4 years ago

Thanks Matt!

mattloper commented 4 years ago

Thank you Paul! And sorry for delays; I'll try to be more responsive in the future.