mattmartini / itivo

Automatically exported from code.google.com/p/itivo
Other
0 stars 0 forks source link

Feature: use mencoder config files for conversion options #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Looking at re-encoder.pl the mencoder options are all passed on the command
line. I wrote up a patch that broke the command line up into different
sections that could then be combined at the end of the script. This allows
for more modularity and makes adding new output formats easier.

Then I discovered mencoder config files. All command line options can be
specified in a config file. I think the conversion profiles should be
written into config files. Selecting a conversion format would move the
correct config file into place. Adding a new conversion format would only
require adding the item to the menu and then writing the config file.

I can do this work if you'd like.

Original issue reported on code.google.com by jerem...@mac.com on 31 Oct 2008 at 3:52

GoogleCodeExporter commented 9 years ago
As it turns out, moving files around the installation repository requires 
priviliges,
so I'm not going to do that.

  However I do like the ability to control mencoder options (so that people can
specify different arguments, etc).  And possibly of having a 'local' config 
file you
can use to set your own settings.  hrmpphh.. gonna need to look at this, 
although not
for a few revisions methinks

Original comment by yoav.yer...@gmail.com on 7 Nov 2008 at 12:14

GoogleCodeExporter commented 9 years ago
I wasn't thinking you'd move the config files around in the installation 
directory, merely store them there as 
templates. mencoder allows you to specify a per-file configuration in 
<filename>.conf in the same directory as 
the input file for example /tmp/iTiVoDLTemp-user.mpg.conf
You could move the needed template (say iphone-medium.con) to that name and 
then specify any special 
overrides the user has on the command line. These command line options would 
override the file specific ones.

Original comment by jerem...@mac.com on 7 Nov 2008 at 1:28

GoogleCodeExporter commented 9 years ago
Ahh I see..
  Yeah I should look into that
  (as well as allow for ways to specify usage of other tools like ffmpeg and whatnot)

Original comment by yoav.yer...@gmail.com on 7 Nov 2008 at 1:33

GoogleCodeExporter commented 9 years ago
Also looking at the command line options in re-encode.pl they could easily be 
grouped into:
audio
video
scaling
device

So that the user does not need to specify the entire command line if they want 
to override one thing.

Original comment by jerem...@mac.com on 7 Nov 2008 at 1:35

GoogleCodeExporter commented 9 years ago
try 1.4b3..  see if you're happy with it...

Original comment by yoav.yer...@gmail.com on 10 Nov 2008 at 8:26

GoogleCodeExporter commented 9 years ago
Wow that was a fast addition. Sorry I took awhile I was traveling on business.
Nice idea storing the command line args in a plist. I haven't looked at the 
apple
script code yet but I'd guess that adding a new option to the plist should also 
add
that option to the menu, right?

I also realized that letting users customize the presets is probably a bad idea 
as it
will make reproducing bugs harder. Perhaps it would be better to add the 
ability for
a user to create their own option sets, so the last option on the Download 
Format
menu would be "New..." or "Custom..." which would allow naming a new config set 
and
saving it to the plist.

Then one final nit, it would be nice if the video/audio/etc command line option 
text
entry fields were multi-line instead of single line. That makes seeing the long 
arg
lists easier.

Original comment by jerem...@mac.com on 14 Nov 2008 at 9:41

GoogleCodeExporter commented 9 years ago
1.5b2 looks much better.
For an app that seems to have the conversions done right check out The 
Application Formerly Known as 
VisualHub:
http://sourceforge.net/projects/transcoderredux

Original comment by jerem...@mac.com on 17 Nov 2008 at 7:56

GoogleCodeExporter commented 9 years ago
Feel free to close this bug. 1.5 works well. I'd still like the ability to save
custom profiles but that is a different enhancement.

Original comment by jerem...@mac.com on 1 Dec 2008 at 5:00

GoogleCodeExporter commented 9 years ago
(Leaving this open since I want to look at visualhub once I get some more free 
time).

  However, as to 'saving' custom profiles,  read up
  http://code.google.com/p/itivo/wiki/CustomFormat

  (that file format is still going extensive changes, and each time that happens your
custom format will need updating... sadly... but it should let you 'do your 
thing' at
least).

Original comment by yoav.yer...@gmail.com on 4 Dec 2008 at 1:25

GoogleCodeExporter commented 9 years ago
Ok closing this ...

Original comment by yoav.yer...@gmail.com on 14 Apr 2009 at 3:26