search

mattmazzola / react-simple-auth

Authentication library for React based on Ember-Simple-Auth
MIT License
56 stars 15 forks source link

feat(provider): add `requestKey` to `buildAuthorizeUrl` #4

Closed geminiyellow closed 6 years ago

geminiyellow commented 6 years ago

Close: #3

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 93.976% when pulling d7ab4db8e59fabb27466d82b9402257fe65e0ae7 on geminiyellow:dev/regist-key into 76dae5c8b0033678e4347de302b4664541949505 on mattmazzola:master.

geminiyellow commented 6 years ago

@mattmazzola how about this.

mattmazzola commented 6 years ago

I'm not sure what issue this PR was intended to solve as the issue you linked to just has the same name as the PR.

In any case, I don't think this would do what you are expecting. The URL that is given to the window should be the authorize URL which is often a redirect to the login page so you would lose any part of it. The only url you can rely on is the callback url after login which is where you extract tokens.