fix(checkWindow): Handle the case where popup windows are blocked in the browser

mattmazzola / react-simple-auth

Authentication library for React based on Ember-Simple-Auth

MIT License

56 stars 15 forks source link

fix(checkWindow): Handle the case where popup windows are blocked in the browser #7

Open artptr opened 4 years ago

artptr commented 4 years ago

window.open returns null if the window couldn't be opened.

coveralls commented 4 years ago

Coverage increased (+0.3%) to 94.318% when pulling 713487a922fcc4018d180df1d103dc6f2c2ef5ec on artptr:fix-null-window into 76dae5c8b0033678e4347de302b4664541949505 on mattmazzola:master.

artptr commented 4 years ago

BTW I have no idea why commit-lint rejects my commit message. I tried to make it using git-cz.