search

mattmc3 / antidote

https://getantidote.github.io - the cure to slow zsh plugin management
MIT License
892 stars 21 forks source link

Is `setopt extended_glob` required? #177

Closed DerRockWolf closed 7 months ago

DerRockWolf commented 7 months ago

Hi, first up thanks for creating antidote :slightly_smiling_face:

I don't want extended_glob to be enabled in zsh. After looking what enabled extended_glob in my setup I found this line in antidote load: https://github.com/mattmc3/antidote/blob/90deef194d38206a0de63980b6147c3a83850055/functions/antidote-load#L8

If I add unsetopt extended_glob after antidote load everything still seems to function as far as I can see. Are there any problems with disabling extended_glob after calling antidote load?

mattmc3 commented 7 months ago

Thanks for the kind words. You got it right - you can run setopt NO_extended_glob or unsetopt extended_glob right after antidote load. There's no problem disabling it as far as antidote is concerned. As long as you don't use a plugin that expects extended_glob, and then you just unset it. Although in that case you could open an issue with the plugin maintainer because if a plugin requires it, setopt local_options extended_glob is the right way to go about it.

mattmc3 commented 7 months ago

@DerRockWolf - I'm going to leave this issue open because now that you mention it, I don't like the side-effect of antidote setting extended_glob. While I've never encountered a situation where I didn't want it, I don't think antidote itself should be responsible for setting it just because it's needed for antidote load. I think it's worth pulling it out to ensure that the use of antidote leaves no side effects outside of what the user loads via plugin.

mattmc3 commented 7 months ago

I cut a new release so that you don't need to do anything once you upgrade to v1.9.6.

DerRockWolf commented 7 months ago

Wow, thanks for looking after it that quickly :heart: