mattmcmanus / atom-ember-snippets

Ember.js ES6 snippets for Atom
https://atom.io/packages/ember-snippets
MIT License
38 stars 22 forks source link

Please update Changelog #1

Closed faddah closed 10 years ago

faddah commented 10 years ago

Your current Changelog only lists up to version 0.3.0 - you're currently on 0.9.5. Please update your Changelog with all historical, relative changes. Thank you.

best,

— faddah wolf portland, oregon, u.s.a. github.com/faddah

seifsallam commented 10 years ago

@faddah 0.9.5 is not correct. When using apm publish <minor/patch> it increments automatically, even if failed to push. So 0.9.5 is not the actual version. And i'm not sure if it's a good idea to set the number manually to 0.3.0 because when getting the package i think it will try to get the latest number.

I don't know much about apm or node publishing, so If you have any ideas to fix this issue, i would really appreciate it.

faddah commented 10 years ago

i do not know either, perhaps contacting @kevinsawicki here on github? he manages both the Atom editor and Atom Package Manager repositories — https://github.com/kevinsawicki. i understand your quandry, but to joe or jane user, it is very confusing, leaving them to wonder if there were any changes since 0.3.0 (tho' i understand that is your current versio.). at least, maybe, update your README.md to openly state the issue and you're working on it, maybe? just a suggestion.

kevinsawicki commented 10 years ago

@seifsallam Publishing failed? Are you still unable to publish new versions?

seifsallam commented 10 years ago

@faddah Ok, thanks for your suggestion, i'll just jump the change log to match package version.

@kevinsawicki No, I had a problem with github 2-way authentication (which is solved now), so I can publish no problems now. This was my first time to deal with apm/npm package management, i didn't realize that failed publishing resulted in appending version number. So i ended up with versions that i don't need.

faddah commented 10 years ago

great job! thank you.