adds module import snippets

mattmcmanus / atom-ember-snippets

Ember.js ES6 snippets for Atom

https://atom.io/packages/ember-snippets

MIT License

38 stars 22 forks source link

Closed jbailey4 closed 7 years ago

jbailey4 commented 7 years ago

@mattmcmanus I added all the snippets as I had them originally, let me know if we want to add/remove some code. The only real differences I see are:

use of leftLabelHTML to add some Ember branding (i.e. #E46651)
the top-level Ember classes are separated into individual snippet files, to allow easier additions/deletions

Closes #24

jbailey4 commented 7 years ago

@mattmcmanus I did try nested folders, but it seems atom doesn't currently support nested snippets, see this issue -> https://github.com/atom/snippets/issues/28

I'm okay with the import- prefix. I'll go ahead and add that.

jbailey4 commented 7 years ago

jbailey4 commented 7 years ago

@mattmcmanus ping.

once this is merged, I'll deprecate atom-ember-module-snippets and instruct users to use this package instead

mattmcmanus commented 7 years ago

Sorry @jbailey4! Time got away from me. I'll cut a release tonight.

mattmcmanus commented 7 years ago

I just shipped 2.1.0 Let me know what you think

jbailey4 commented 7 years ago

@mattmcmanus No problem. Updated and looks good 👍 thanks for getting this in