search

mattmcmanus / atom-ember-snippets

Ember.js ES6 snippets for Atom
https://atom.io/packages/ember-snippets
MIT License
38 stars 22 forks source link

Pro fancy version for coffeeScript syntax #3

Closed imanghafoori1 closed 7 years ago

imanghafoori1 commented 9 years ago

Happy to see your comments...

seifsallam commented 9 years ago

You've done some awesome work, and i like the new file structure (except for other, and wrappers).

About having shorthand + long form

When we type, we type words not characters (same way we read). We don’t think about single characters in isolation. We don’t type f-i-n-d, we think find, and type find as a whole. And typing partial characters break this flow, as you have to be consciously thinking about what you type.

I understand your point of view. And I’ve used it before, but it didn’t turnout well, especially when collaboration with other. Everyone had their way of naming things, and their own conventions, despite having a clear guidelines. Even you couple of month not using ember, and going back you'll have all those shorthands forgotten. (Saying this from an experience)

Plus, most of the words are not that big, with the exception of a few. I simply don’t see the point in changing the way we type find for the sake of few long words.

Another main issue is that if atom fixes or supports autocomplete for snippets tomorrow, having shorthand should be deprecated, or it will generate 2 autocomplete suggestions for each snippet. So again, I appreciate the amount of effort that you've put into this, but it will be harder for you to maintain such thing.

imanghafoori1 commented 9 years ago

ok, I agree with you. removing the short hands is as simple as removing the wrapper.cson file and then the rest of the package would get on pretty well... ;) of course except the --help commands which need to be modified.

*--help snippets (such as model--help) Are meant to be used in case you or forget or suspect what to type! they can recover your memory about what to use, quickly and effortlessly.

I tried to design the package in a way that if the user is not happy with the shorthands he or she can ignore them all together.

no big deal. ;)

with the help of this nice handy package, it seems redundant to have the shorthands. I wish there is a way to recommend it to users along side the current one.

I remove the wrappers and shorthands on the next commit. And we will be good to go.

imanghafoori1 commented 9 years ago

After all thank you for comments. sayyedi ;) shokran

seifsallam commented 9 years ago

Awesome. About the snippets, we can add it to the README file as something recommended to use with.

seifsallam commented 9 years ago

Can you run the files against a coffee script linter, to clean things up, like removing extra lines, and spaces before comas, and other small stuff like that for consistency.

Other than that, and the inline comments, your work looks pretty good! :+1:

imanghafoori1 commented 9 years ago

I am working on a much better branch specially optimized to work with "autocomplete-snippets" package. I bet you`ll find that fantastic.