search

mattmcmanus / atom-ember-snippets

Ember.js ES6 snippets for Atom
https://atom.io/packages/ember-snippets
MIT License
38 stars 22 forks source link

Improve inject.service snippet #43

Closed Exelord closed 6 years ago

Exelord commented 6 years ago

as iminjectService adds: import { inject as service } from '@ember/service'; it makes sense to change this snippet to just service(${1}),

https://github.com/mattmcmanus/atom-ember-snippets/blob/99eb8cdd7c9f6abb14a685cd611330b79a6ad0cd/snippets/ember.cson#L66-L69

Exelord commented 6 years ago

Why its closed? Its not fixed

mattmcmanus commented 6 years ago

Hey @Exelord, make sure to check the recent commits: https://github.com/mattmcmanus/atom-ember-snippets/commit/306760aa33080ed1b73fc85e1f5baf458e5c214f

I'm going to thrashing in here for a little bit making a bunch of tweaks. I should I have a release out before I wrap up for the night.

mattmcmanus commented 6 years ago

Published in 3.0.0!