search

mattmcmanus / atom-ember-snippets

Ember.js ES6 snippets for Atom
https://atom.io/packages/ember-snippets
MIT License
38 stars 22 forks source link

Await tests helpers #44

Closed Exelord closed 6 years ago

Exelord commented 6 years ago

Now it makes sense to put await before every helper as they are async Promises

https://github.com/mattmcmanus/atom-ember-snippets/blob/99eb8cdd7c9f6abb14a685cd611330b79a6ad0cd/snippets/ember.cson#L332-L360

jrock2004 commented 6 years ago

This is a tough one because not everyone uses the new test format style. I would gladly fix this if @mattmcmanus thinks it should be updated

Exelord commented 6 years ago

The package should always follow the latest trends.

mattmcmanus commented 6 years ago

@Exelord and @jrock2004: That's a tough call. I'm doing some work on this tonight so I'll think it through. Right now, I'm thinking I'll use the newest patterns with the option to select the awaits\ at the end and remove them if you want. Another option is to prefix the snippets with a, so avisit would do await visit($1) and visit would the plain ol' one. Feel free to weigh in!

Exelord commented 6 years ago

I think we should just move forward. This pattern is already over 1 year old. We should push users to upgrade as this is almost at no cost.

mattmcmanus commented 6 years ago

@Exelord Agreed. I'm in the process of bringing in snippets for most of the ember-test-snippets package.

mattmcmanus commented 6 years ago

Published in 3.0.0!