Add snippets for Ember Enumerables

mattmcmanus / atom-ember-snippets

Ember.js ES6 snippets for Atom

https://atom.io/packages/ember-snippets

MIT License

38 stars 22 forks source link

Add snippets for Ember Enumerables #6

Closed taylon closed 9 years ago

taylon commented 9 years ago

Enumerables are quite common currently so I added all the ones supported both in js and coffee =D

seifsallam commented 9 years ago

That's awesome (sorry for the late reply). Can you just remove variable assignment, match prefix with function name (ex: use forEach instead fore), and remove functions that existing in JS autocomplete like .filter and .map. Thanks :)

seifsallam commented 9 years ago

Also can you update the README

taylon commented 9 years ago

Absolutely, I'll do it until the end of the week.

taylon commented 9 years ago

@seifsallam a couple of questions:

Variable assignment: Do you really think we should remove it? Those methods are most of the time used with variable assignment (at least as far as I know). In addition to that, I made all of them optional, so if you just hit backspace they will be removed and you can move to the next breakpoint and continue filling the snippet.
.filter and .map: I checked the language-javascript and they are not there, you mean another package that includes it?

I already updated the prefixes to match function names and the README, just wanted to discuss these two before the pull request.

seifsallam commented 9 years ago

@taylon

Yes, and yes, but I believe it should be up to the user to assign it to a variable themselves. Some prefer defining variables at the top, some would want to chain methods. Problem with backspace that it would break users typing flow, so it's the better to keep it simple.
Yes, I'm actually using https://atom.io/packages/turbo-javascript

taylon commented 9 years ago

@seifsallam

Cool, so there we go, let me know if there is any other change you would like to see.

seifsallam commented 9 years ago

@taylon Awesome. Thanks for the PR :+1: :)