search

mattmcspirit / azurestack

Azure Stack Resources
80 stars 41 forks source link

Typo at line 1692 #34

Closed devalian closed 6 years ago

devalian commented 6 years ago

$packageArray = "Microsoft.WindowsServer2016Datacenter-ARM", "Microsoft.WindowsServer2016DatacenterCore-ARM"

Corrected version is as below: $packageArray = "Microsoft.WindowsServer2016Datacenter-ARM", "Microsoft.WindowsServer2016DatacenterServerCore-ARM"

devalian commented 6 years ago

Line 1708 , got some script logic issue. $Upload = Add-AzsGalleryItem -GalleryItemUri $galleryItemUri -Force -Confirm:$false -ErrorAction Stop

$galleryItemUri is somehow empty for me. and the logic indeed doesnt populate the items for gallery to be uploaded. which relate to my title, where servercore is missing and unable to upload.

mattmcspirit commented 6 years ago

Thank you! I think the names of the Server Core marketplace item changed slightly in the official marketplace - I'll update the logic shortly. If you want to make the change that you added in your first post, in your ConfigAsdk.ps1 file, and rerun the script, it should pick up from there. Thanks!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Reng Kwan notifications@github.com Sent: Wednesday, August 1, 2018 5:56 AM To: mattmcspirit/azurestack Cc: Subscribed Subject: Re: [mattmcspirit/azurestack] Typo at line 1692 (#34)

Line 1708 , got some script logic issue. $Upload = Add-AzsGalleryItem -GalleryItemUri $galleryItemUri -Force -Confirm:$false -ErrorAction Stop

$galleryItemUri is somehow empty for me. and the logic indeed doesnt populate the items for gallery to be uploaded. which relate to my title, where servercore is missing and unable to upload.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmattmcspirit%2Fazurestack%2Fissues%2F34%23issuecomment-409565099&data=02%7C01%7CMatt.McSpirit%40microsoft.com%7C39787c4d485e4a1e46c008d5f7ae34b8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636687249945231386&sdata=tzJGuA44%2Bjm3VY04e8eoeM5uukydpLHlsCbj3S0h7LQ%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATQYKmDs97J-Nh28aWZ4m5x4VyMGuhSLks5uMaV_gaJpZM4VqXsI&data=02%7C01%7CMatt.McSpirit%40microsoft.com%7C39787c4d485e4a1e46c008d5f7ae34b8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636687249945241407&sdata=OcYGs5v2ZXe%2FLgSn3J6R9INUdqvGZwLJfLf3c60Cz9E%3D&reserved=0.

devalian commented 6 years ago

Great to hear from you @mattmcspirit. the scripts seems to be running good for me, after 2 changes i highlighted above. will update if i bump into anything else.

cheers!

mattmcspirit commented 6 years ago

Awesome, thanks!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Reng Kwan notifications@github.com Sent: Wednesday, August 1, 2018 6:52 AM To: mattmcspirit/azurestack Cc: Matt McSpirit; Mention Subject: Re: [mattmcspirit/azurestack] Typo at line 1692 (#34)

Great to hear from you @mattmcspirithttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmattmcspirit&data=02%7C01%7CMatt.McSpirit%40microsoft.com%7C5c104916b60440db7ec508d5f7b5f868%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636687283281379855&sdata=YiGIXBrwoJkT13sfqrzmPXGJK%2BZTFcBSxEOEz6rGgio%3D&reserved=0. the scripts seems to be running good for me, after 2 changes i highlighted above. will update if i bump into anything else.

cheers!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmattmcspirit%2Fazurestack%2Fissues%2F34%23issuecomment-409581964&data=02%7C01%7CMatt.McSpirit%40microsoft.com%7C5c104916b60440db7ec508d5f7b5f868%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636687283281379855&sdata=rqDHJJW90HXXU7zfV3q6yz4kfTel3q%2FMnl%2FOL76ClLg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATQYKmzebLKe62rL9s6xAoIU_PsDiA02ks5uMbKGgaJpZM4VqXsI&data=02%7C01%7CMatt.McSpirit%40microsoft.com%7C5c104916b60440db7ec508d5f7b5f868%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636687283281379855&sdata=vVaqpiDYgsblNta5m8KwFaNDOIK8VLUO0mUJ3TQGTO8%3D&reserved=0.

mattmcspirit commented 6 years ago

Should be fixed and live now! New version coming soon too! :)